agents 297e32a617cea1074aeba66c

Code review: [AML] Update README after deprecated experiment config removal

agents/history/99f8e54f-0965-4727-aa2c-0309c34cb939.md

agent_session_path: /home/kyhuang/.codex/sessions/2026/09/14/rollout-2026-09-14T16-58-44-01a0a0db-55ad-7df1-88e1-5f7f82cf7802.jsonl base_branch: av-dev-l2pp-2 branch: dylanbot/99f8e54f-code-review-aml-upd chat_id: 01a0a0db-55ad-7df1-88e1-5f7f82cf7802 completed_at: 1789405335.7688913 completion_artifact_status: not_required created_at: 1789405084.812685 definition_of_done:

  • Review findings are grounded in the diff and ordered by severity.

  • NDAS terminology and timestamp assumptions are checked.

  • Unresolved questions are surfaced to Dylan instead of guessed.

  • Draft comments are prepared or posted only as unpublished Gerrit drafts, or Dylan explicitly decides not to draft them.

  • Dylan remains the sole publisher for any Gerrit review comments, labels, votes, messages, retriggers, or submit actions.

  • The review thread is tracked until drafts are handled or the task is handed off. description: "# Code review: [AML] Update README after deprecated experiment config
    \ removal\n- Author: yush\n- Platform: gerrit\n- URL: https://git-av.nvidia.com/r/c/ndas/+/958760\n
    \n## DRAFTS ONLY \u2014 NEVER PUBLISH\n\nThis is a Gerrit code-review task. You
    \ may prepare draft comments, but you must\nnever publish anything to Gerrit. Dylan
    \ is the sole publisher.\n\nForbidden publish paths and equivalents:\n- Do not call
    \ POST /changes/.../revisions/.../review or\n POST /a/changes/.../revisions/.../review.\n\

    • Do not run dylanbot gerrit review, dylanbot gerrit draft publish,\n dylanbot\ \ gerrit retrigger, gerrit review, git review\n publish/vote/message options,
      \ glab/gerrit publish equivalents, or any\n raw curl/script/browser automation
      \ that posts a Gerrit review, label, vote,\n message, or submit action.\n\nCorrect
      \ draft-only path:\n- The only Gerrit write path allowed for review comments is\n
      \ PUT /changes/.../revisions/.../drafts or\n PUT /a/changes/.../revisions/.../drafts.\n\
    • For this task, prefer not to write to Gerrit yourself. Emit the JSON findings\n
      \ requested below; DylanBot will create unpublished Gerrit drafts from that JSON.\n
      \n\n## Step 1: Fetch the CL into this worktree\n\nbash\ngit fetch origin refs/changes/60/958760/2\ \ && git checkout FETCH_HEAD\n\n\nIf that doesn't work, try fetching the specific
      \ patchset:\nbash\ncurl -s -n 'https://git-av.nvidia.com/r/a/changes/958760?o=CURRENT_REVISION'\ \ | tail -n +2 | jq -r '.current_revision as $rev | .revisions[$rev].ref'\n\n
      Then git fetch origin <ref> && git checkout FETCH_HEAD.\n\nDylanBot pinned this
      \ review launch to patchset 2 at revision 979adc1653b48a1f1992c71a2200433720e97ce8.
      \ If Gerrit moves to a new patchset before completion, DylanBot will block draft
      \ posting and ask for a fresh review.\n\n\n## Step 2: Read the code-review rule\n
      \nRead .cursor/rules/code-review.mdc in this worktree if it exists. Also read
      \ ~/.cursor/rules/gerrit-code-review.mdc for Gerrit CLs. Follow their tone, conventions,
      \ and review guidelines.\n\n## Step 3: Review the code\n\nRead the changed files
      \ and review them thoroughly. Focus on correctness, edge cases, naming, and style.
      \ Match Dylan's writing tone (lowercase, concise, conversational).\n\n## Step 4:
      \ Emit structured comments (machine-parseable record)\n\nProduce inline review comments
      \ as a JSON array, in this exact shape:\njson\n[{\"file\": \"path/to/file\",\ \ \"line\": 42, \"comment\": \"...\", \"severity\": \"info|warning|error\"}]\n\n
      \nPut the JSON array in a ```json fenced block in the task result. This is the
      \ only thing the daemon needs from you.       DylanBot will read this block and post
      \ each entry as an unpublished draft comment to the correct file/line on the CL
      \ using its Gerrit integration. You do not need to post anything yourself \u2014
      \ no curl, no API calls, no git review. Drafts only; Dylan will publish them himself
      \ in the Gerrit UI.\n\n## Diff summary (for orientation \u2014 review the actual
      \ files, not just this):\n\n{\n "project": "ndas",\n "branch": "av-dev-l2pp-2"
      ,\n "hashtags": [\n "ZeroRisk",\n "comp-alpamayo"\n ],\n "change_id"
      : "Ic9e4eb35905f3b5ba094de066496766f99b36534",\n "subject": "[AML] Update
      \ README after deprecated experiment config removal",\n "status": "NEW",\n
      \ "created": "2026-09-11 19:47:49.000000000",\n "updated": "2026-09-12
      \ 18:50:16.000000000",\n "submit_type": "REBASE_ALWAYS",\n "insertions"
      : 43,\n "deletions": 91,\n "total_comment_count": 2,\n "unresolved_comment_count"
      : 0,\n "_number": 958760,\n "owner": "Yu Shen",\n "reviewers": [\n
      \ "Gerrit Virtual Submit",\n "gitavsvc-r2d2"\n ],\n "label_votes": {\n
      \ "GVS": [\n {\n "name": "Gerrit Virtual Submit",\n
      \ "value": 1\n }\n ],\n "In-Car-Test": [\n {\n "name"
      : "gitavsvc-r2d2",\n "value": 4\n }\n ],\n "PLC": [\n
      \ {\n "name": "gitavsvc-r2d2",\n "value": 1\n }\n
      \ ]\n },\n "recent_messages": [\n {\n "author": "gitavsvc-alfred-premerge"
      ,\n "date": "2026-09-12 15:03:06.000000000",\n "message": "Hashtag
      \ added: ZeroRisk\nHashtag removed: LowRisk"\n },\n {\n "author"
      : "gitavsvc-alfred-premerge",\n "date": "2026-09-12 15:03:07.000000000"
      ,\n "message": "Patch Set 2:\n\nyush@nvidia.com set the Integration Risk
      \ to ZeroRisk."\n },\n {\n "author": "svcjenkinsavbt",\n "
      date": "2026-09-12 15:10:51.000000000",\n "message": "Patch Set 2:\
      n\nPremerge code coverage started at https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/opt-in/job/coverage-linux-cuda-vcast-automatic/55100/"
      \n },\n {\n "author": "svcteststudio",\n "date": "2026-09-12
      \ 15:12:42.000000000",\n "message": "Patch Set 2:\n\nTestStudio premerge
      \ tests PASSED.\nResults: https://maglev.nvda.ai/ui/teststudio/jobs/01a0962b-40ed-788a-024e-c21a985ff689\
      n\nSuite: pmb-gating-msf-minimal-av-dev-l2pp-2. \u2705 1 \u2197\
      n\nFor additional support, visit: https://maglev.nvda.ai/docs/components/eval/faq"
      \n },\n {\n "author": "gitavsvc-ugiza-jenkins",\n "date":
      \ "2026-09-12 15:19:20.000000000",\n "message": "Patch Set 2:\n\nUGiza
      \ Documentation Build SKIPPED\nNo impacted Element/Unit pairs were found; Doxygen
      \ premerge was skipped.\nBuild link: https://prod.blsm.nvidia.com/sw-mobile-av-prod/job/ndas/job/docs/job/doxygen-premerge/job/doxygen-premerge-element-unit-check/49773/"
      \n },\n {\n "author": "svcjenkinsavbt",\n "date": "2026-09-12
      \ 15:20:52.000000000",\n "message": "Patch Set 2:\n\nCoverage SKIPPED:
      \ This CL does not touch any units defined in //av/safety/module_lists.bzl https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/opt-in/job/coverage-linux-cuda-vcast-automatic/55100/"
      \n },\n {\n "author": "Gerrit Virtual Submit",\n "date": "
      2026-09-12 18:32:42.000000000",\n "message": "Patch Set 2:\n\nVirtual
      \ submitted; http://testbot.nvidia.com/testbot/view/content/change/changeDetail.jsf?bseid=10154793&bsid=7;
      \ Link to nvci UI: https://nvci-apps.nvidia.com/ci/pipelines/10154793; bseid: 10154793;
      \ Please try out new SPACE UI (Beta): https://space.nvidia.com/pipelines/details?bseId=10154793&bsId=7;
      \ ;"\n },\n {\n "author": "Gerrit Virtual Submit",\n "date"
      : "2026-09-12 18:48:37.000000000",\n "message": "Patch Set 2: GVS+1\
      n\nGVS successful; Build(s) successful; Test(s) successful; http://testbot.nvidia.com/testbot/view/content/change/changeDetail.jsf?bseid=10154793&bsid=7;
      \ Link to nvci UI: https://nvci-apps.nvidia.com/ci/pipelines/10154793; bseid: 10154793;
      \ Please try out new SPACE UI (Beta): https://space.nvidia.com/pipelines/details?bseId=10154793&bsId=7;
      \ In case of failures related to os-secured-g builds/packages/tests, please check
      \ https://confluence.nvidia.com/display/OSG/os-secured-g+build"\n },\n {\n
      \ "author": "svcenomis",\n "date": "2026-09-12 18:48:45.000000000"
      ,\n "message": "Patch Set 2:\n\nUsing https://nvci-apps.nvidia.com/ci/pipelines/10154793;
      \ to identify dependencies: No dependencies found for this change. To override the
      \ dependencies identified, Please refer to https://confluence.nvidia.com/x/jgYcQg
      \ for more details."\n },\n {\n "author": "gitavsvc-r2d2",\n
      \ "date": "2026-09-12 18:50:16.000000000",\n "message": "Patch Set
      \ 2: In-Car-Test+4 PLC+1\n\nStability lockdown exception granted (Granted (verified-safe
      \ files only) without a build)\n\nASE report: https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/stabilization-lockdown/job/build-auto-stability-exception/261441/artifact/ase-report.html\
      nJenkins build: https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/stabilization-lockdown/job/build-auto-stability-exception/261441/"
      \n }\n ]\n}\n\n## Project notes:\n\n" exit_code: 0 lifecycle_policy: ndas.code_review merge_failure_kind: cleanup_dirty_worktree merge_sha: c353de6f54f9d6d5cfc45a148bfbb0b5ecd9fd97 parent_channel: D0BET9CTWCW parent_ts: '1789405121.977239' pid: 4107754 prompt_manifest_algorithm_version: 1 prompt_manifest_hash: 7290fd2a2bdd45bc002d491f6a9bbe03f31fc87da1c15223ad787d57c1fc88c4 prompt_manifest_path: /home/kyhuang/.config/dylanbot/memory/agents/prompts/99f8e54f-0965-4727-aa2c-0309c34cb939.json prompt_manifest_schema_version: 1 prompt_part_count: 8 prompt_rendered_hash: d4bd10dbfc3b00d62d928909c926d8e3140dd4f30f72ba66bde02473481c16b8 repo: /home/kyhuang/scratch/ndas repo_family: ndas result_summary: 'Refusing cleanup: /home/kyhuang/.config/dylanbot/worktrees/99f8e54f-0965-4727-aa2c-0309c34cb939 has dirty files after merge.

    Task status: completed.

    Backlog item: none.

    Dirty files:

    • ?? .cursor/rules/dylanbot-auto-merge.md (differs from av-dev-l2pp-2)

    • ?? .cursor/rules/dylanbot-handoff.md (differs from av-dev-l2pp-2)

    • ?? .cursor/rules/dylanbot-subagent.md (differs from av-dev-l2pp-2)' runtime: codex runtime_command: codex runtime_invocation_profile: codex.exec.yolo_json runtime_mode: cli runtime_requested_mode: cli source_event_id: '' source_intent: code_review_request spawn_context_algorithm_version: 1 spawn_context_bundle_hash: 74cf03e635081d6c8b6aa9efb179d08baa8ded6ffb5c0f24c9e6d9fd9b0a5002 spawn_context_bundle_path: /home/kyhuang/.config/dylanbot/memory/agents/context/99f8e54f-0965-4727-aa2c-0309c34cb939.json spawn_context_item_count: 6 spawn_context_schema_version: 1 spawn_contract_status: valid spawn_policy: auto stage_spec_algorithm_version: 2 stage_spec_hash: 404ebfd6213eb34537baf06db46d5677bc99f86c736ff5179799714fe3a3fc8f stage_spec_id: stage:99f8e54f-0965-4727-aa2c-0309c34cb939:v0 stage_spec_path: /home/kyhuang/.config/dylanbot/memory/agents/stages/99f8e54f-0965-4727-aa2c-0309c34cb939.json stage_spec_schema_version: 1 started_at: 1789405121.8254466 status: merge_failed success_criteria:

  • Review the requested NDAS CL/diff for correctness, regressions, and missing tests.

  • Check NDAS-specific terminology and data assumptions.

  • Draft Gerrit review comments only; never publish comments, labels, votes, messages, retriggers, or submit actions. task_id: 99f8e54f-0965-4727-aa2c-0309c34cb939 task_kind: code_review thread_ts: '1789405121.977239' timeout_minutes: 30 worktree: /home/kyhuang/.config/dylanbot/worktrees/99f8e54f-0965-4727-aa2c-0309c34cb939

Task

Code review: [AML] Update README after deprecated experiment config removal

  • Author: yush
  • Platform: gerrit
  • URL: https://git-av.nvidia.com/r/c/ndas/+/958760

DRAFTS ONLY — NEVER PUBLISH

This is a Gerrit code-review task. You may prepare draft comments, but you must never publish anything to Gerrit. Dylan is the sole publisher.

Forbidden publish paths and equivalents:

  • Do not call POST /changes/.../revisions/.../review or POST /a/changes/.../revisions/.../review.
  • Do not run dylanbot gerrit review, dylanbot gerrit draft publish, dylanbot gerrit retrigger, gerrit review, git review publish/vote/message options, glab/gerrit publish equivalents, or any raw curl/script/browser automation that posts a Gerrit review, label, vote, message, or submit action.

Correct draft-only path:

  • The only Gerrit write path allowed for review comments is PUT /changes/.../revisions/.../drafts or PUT /a/changes/.../revisions/.../drafts.
  • For this task, prefer not to write to Gerrit yourself. Emit the JSON findings requested below; DylanBot will create unpublished Gerrit drafts from that JSON.

Step 1: Fetch the CL into this worktree

git fetch origin refs/changes/60/958760/2 && git checkout FETCH_HEAD

If that doesn't work, try fetching the specific patchset:

curl -s -n 'https://git-av.nvidia.com/r/a/changes/958760?o=CURRENT_REVISION' | tail -n +2 | jq -r '.current_revision as $rev | .revisions[$rev].ref'

Then git fetch origin <ref> && git checkout FETCH_HEAD.

DylanBot pinned this review launch to patchset 2 at revision 979adc1653b48a1f1992c71a2200433720e97ce8. If Gerrit moves to a new patchset before completion, DylanBot will block draft posting and ask for a fresh review.

Step 2: Read the code-review rule

Read .cursor/rules/code-review.mdc in this worktree if it exists. Also read ~/.cursor/rules/gerrit-code-review.mdc for Gerrit CLs. Follow their tone, conventions, and review guidelines.

Step 3: Review the code

Read the changed files and review them thoroughly. Focus on correctness, edge cases, naming, and style. Match Dylan's writing tone (lowercase, concise, conversational).

Step 4: Emit structured comments (machine-parseable record)

Produce inline review comments as a JSON array, in this exact shape:

[{"file": "path/to/file", "line": 42, "comment": "...", "severity": "info|warning|error"}]

Put the JSON array in a ```json fenced block in the task result. This is the only thing the daemon needs from you. DylanBot will read this block and post each entry as an unpublished draft comment to the correct file/line on the CL using its Gerrit integration. You do not need to post anything yourself — no curl, no API calls, no git review. Drafts only; Dylan will publish them himself in the Gerrit UI.

Diff summary (for orientation — review the actual files, not just this):

{ "project": "ndas", "branch": "av-dev-l2pp-2", "hashtags": [ "ZeroRisk", "comp-alpamayo" ], "change_id": "Ic9e4eb35905f3b5ba094de066496766f99b36534", "subject": "[AML] Update README after deprecated experiment config removal", "status": "NEW", "created": "2026-09-11 19:47:49.000000000", "updated": "2026-09-12 18:50:16.000000000", "submit_type": "REBASE_ALWAYS", "insertions": 43, "deletions": 91, "total_comment_count": 2, "unresolved_comment_count": 0, "_number": 958760, "owner": "Yu Shen", "reviewers": [ "Gerrit Virtual Submit", "gitavsvc-r2d2" ], "label_votes": { "GVS": [ { "name": "Gerrit Virtual Submit", "value": 1 } ], "In-Car-Test": [ { "name": "gitavsvc-r2d2", "value": 4 } ], "PLC": [ { "name": "gitavsvc-r2d2", "value": 1 } ] }, "recent_messages": [ { "author": "gitavsvc-alfred-premerge", "date": "2026-09-12 15:03:06.000000000", "message": "Hashtag added: ZeroRisk\nHashtag removed: LowRisk" }, { "author": "gitavsvc-alfred-premerge", "date": "2026-09-12 15:03:07.000000000", "message": "Patch Set 2:\n\nyush@nvidia.com set the Integration Risk to ZeroRisk." }, { "author": "svcjenkinsavbt", "date": "2026-09-12 15:10:51.000000000", "message": "Patch Set 2:\n\nPremerge code coverage started at https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/opt-in/job/coverage-linux-cuda-vcast-automatic/55100/" }, { "author": "svcteststudio", "date": "2026-09-12 15:12:42.000000000", "message": "Patch Set 2:\n\nTestStudio premerge tests PASSED.\nResults: https://maglev.nvda.ai/ui/teststudio/jobs/01a0962b-40ed-788a-024e-c21a985ff689\n\nSuite: pmb-gating-msf-minimal-av-dev-l2pp-2. \u2705 1 \u2197\n\nFor additional support, visit: https://maglev.nvda.ai/docs/components/eval/faq" }, { "author": "gitavsvc-ugiza-jenkins", "date": "2026-09-12 15:19:20.000000000", "message": "Patch Set 2:\n\nUGiza Documentation Build SKIPPED\nNo impacted Element/Unit pairs were found; Doxygen premerge was skipped.\nBuild link: https://prod.blsm.nvidia.com/sw-mobile-av-prod/job/ndas/job/docs/job/doxygen-premerge/job/doxygen-premerge-element-unit-check/49773/" }, { "author": "svcjenkinsavbt", "date": "2026-09-12 15:20:52.000000000", "message": "Patch Set 2:\n\nCoverage SKIPPED: This CL does not touch any units defined in //av/safety/module_lists.bzl https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/opt-in/job/coverage-linux-cuda-vcast-automatic/55100/" }, { "author": "Gerrit Virtual Submit", "date": "2026-09-12 18:32:42.000000000", "message": "Patch Set 2:\n\nVirtual submitted; http://testbot.nvidia.com/testbot/view/content/change/changeDetail.jsf?bseid=10154793&bsid=7; Link to nvci UI: https://nvci-apps.nvidia.com/ci/pipelines/10154793; bseid: 10154793; Please try out new SPACE UI (Beta): https://space.nvidia.com/pipelines/details?bseId=10154793&bsId=7; ;" }, { "author": "Gerrit Virtual Submit", "date": "2026-09-12 18:48:37.000000000", "message": "Patch Set 2: GVS+1\n\nGVS successful; Build(s) successful; Test(s) successful; http://testbot.nvidia.com/testbot/view/content/change/changeDetail.jsf?bseid=10154793&bsid=7; Link to nvci UI: https://nvci-apps.nvidia.com/ci/pipelines/10154793; bseid: 10154793; Please try out new SPACE UI (Beta): https://space.nvidia.com/pipelines/details?bseId=10154793&bsId=7; In case of failures related to os-secured-g builds/packages/tests, please check https://confluence.nvidia.com/display/OSG/os-secured-g+build" }, { "author": "svcenomis", "date": "2026-09-12 18:48:45.000000000", "message": "Patch Set 2:\n\nUsing https://nvci-apps.nvidia.com/ci/pipelines/10154793; to identify dependencies: No dependencies found for this change. To override the dependencies identified, Please refer to https://confluence.nvidia.com/x/jgYcQg for more details." }, { "author": "gitavsvc-r2d2", "date": "2026-09-12 18:50:16.000000000", "message": "Patch Set 2: In-Car-Test+4 PLC+1\n\nStability lockdown exception granted (Granted (verified-safe files only) without a build)\n\nASE report: https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/stabilization-lockdown/job/build-auto-stability-exception/261441/artifact/ase-report.html\nJenkins build: https://prod.blsm.nvidia.com/sw-mobile-av-prod-ci/job/ndas/job/stabilization-lockdown/job/build-auto-stability-exception/261441/" } ] }

Project notes:

Context

Definition of Done

Policy: ndas.code_review

Spawn policy: auto

  • Review findings are grounded in the diff and ordered by severity.
  • NDAS terminology and timestamp assumptions are checked.
  • Unresolved questions are surfaced to Dylan instead of guessed.
  • Draft comments are prepared or posted only as unpublished Gerrit drafts, or Dylan explicitly decides not to draft them.
  • Dylan remains the sole publisher for any Gerrit review comments, labels, votes, messages, retriggers, or submit actions.
  • The review thread is tracked until drafts are handled or the task is handed off.

Success Criteria

  • Review the requested NDAS CL/diff for correctness, regressions, and missing tests.
  • Check NDAS-specific terminology and data assumptions.
  • Draft Gerrit review comments only; never publish comments, labels, votes, messages, retriggers, or submit actions.

Spawn Context Bundle

  • Schema: 1
  • Algorithm: 1
  • Hash: 74cf03e635081d6c8b6aa9efb179d08baa8ded6ffb5c0f24c9e6d9fd9b0a5002
  • Manifest: /home/kyhuang/.config/dylanbot/memory/agents/context/99f8e54f-0965-4727-aa2c-0309c34cb939.json
  • Included items: 6
  • Before implementing, read the referenced rules, memory pointers, and recent related-work hits in the manifest.

Existing State Audit

Complete this before editing code:

  • Searches run:
  • Existing implementations or related code found:
  • Reuse/extend decision:

Stage Contract

  • Schema: 1
  • Algorithm: 2
  • Stage spec id: stage:99f8e54f-0965-4727-aa2c-0309c34cb939:v0
  • Stage spec hash: 404ebfd6213eb34537baf06db46d5677bc99f86c736ff5179799714fe3a3fc8f
  • Stage spec: /home/kyhuang/.config/dylanbot/memory/agents/stages/99f8e54f-0965-4727-aa2c-0309c34cb939.json

Prompt Provenance

  • Schema: 1
  • Algorithm: 1
  • Manifest hash: 7290fd2a2bdd45bc002d491f6a9bbe03f31fc87da1c15223ad787d57c1fc88c4
  • Rendered prompt hash: d4bd10dbfc3b00d62d928909c926d8e3140dd4f30f72ba66bde02473481c16b8
  • Manifest: /home/kyhuang/.config/dylanbot/memory/agents/prompts/99f8e54f-0965-4727-aa2c-0309c34cb939.json
  • Prompt parts: 8
  • Runtime command: codex
  • Runtime invocation profile: codex.exec.yolo_json
  • Runtime model: not reported by runtime config

Progress

Result

I'll start by reading the task file and the relevant review rules, then fetch the CL.

Let me check the spawn context, rules, and fetch the CL.

No code-review rule file in the expected spots — let me look at the available rules and the review history to match tone.

Let me look at prior review outputs to calibrate tone and format, then fetch the CL.

Fetch succeeded — now checking out and inspecting the diff.

Single README change. Let me examine the full diff and the related experiment config files to verify accuracy.

Diff was truncated in the middle — let me view the full diff in chunks.

Let me pull the whole diff in manageable chunks and verify config/experiment references against the actual tree.

Now let me verify all referenced config paths and experiment names against the actual tree at this revision.

All referenced configs exist and deprecated ones are gone — good. Now let me verify the pipeline descriptions against the actual DAG YAMLs.

Let me check the remaining DAG configs for accuracy of the new descriptions and the dflash params.

Descriptions check out. Now scanning the full new README for any leftover stale references to the deprecated configs.

No stale references remain. Let me verify the manual-resubmit example's stage names against the actual launch layout, and view the new README sections for exact line context.

Confirmed the job.sh layout. Now let me view the new README sections with exact line numbers for anchoring comments.

Now checking the DAG _defaults.yaml templates and the AMO export experiment to sanity-check the new-DAG example, plus whether pretrain_only CLE is conditional.

Let me inspect the export template and how the launcher handles CLE conditioning, to confirm the example accuracy claims.

Let me confirm how the launcher gates CLE jobs, to decide whether the e2e table's "→ CLE" wording is consistent.

Let me check whether the launcher filters CLE jobs based on --cle-config, to gauge the "optional CLE" wording consistency.

Confirmed — _validate_and_filter_cle_jobs strips CLE when no --cle-config is passed, so CLE is optional in all these DAGs. Let me pin the exact new-file line numbers for the comments.

Let me view the second DAG-details table (lines 670-745) for cross-table consistency context, then finalize.

The README itself (lines 670-676) already states CLE only runs with --cle-config — so the new table's unconditional "→ CLE" wording is inconsistent. Let me do a final sweep for leftover aml_sft_cosmos-style refs and confirm line numbers for comment anchors.

All paths verified, no stale refs remain. Let me update the task progress file, then finalize the findings.

Progress-file write didn't persist (likely a managed read-only area) — not critical; the deliverable is the JSON findings. Let me verify the write path once more quickly, then finish.

Progress file is daemon-managed (writes don't stick) — that's fine, the deliverable is the findings JSON. Review complete.

Review summary

This is a clean, docs-only CL (43 insertions / 91 deletions) updating avdnn/dlav/aml/README.md after the deprecated m1_5/, mfmc/, m1_5_cosmos/, and amor_* experiment-config removal. I verified against the tree at this revision:

  • Every referenced config resolves: conf/dag/mcmf_cosmos/{e2e,pretrain_only,sft_only,ptq_only,fp8_export_only,evaluate_only,dflash_ptq_tokenize_export}.yaml, conf/cle/aml_mcmf_sft_cosmos.yaml, experiments aml_mcmf_{alignment,pretrain,sft}_cosmos, amo_mcmf_sft, amo_mcmf/ DAGs.
  • No stale references remain (m1_5, mfmc, amor_*, aml_sft_cosmos, main.py, tokenize_only all gone).
  • DAG table descriptions, the DFlash sft_resolved_config_path instructions, and the sbatch manual-resume stage names (sft → merge_lora → calibrate → export/job.sh) all match the actual YAMLs (scripts/dag/config_loader.py _validate_and_filter_cle_jobs, launch_dag.py, _defaults.yaml templates, amo_mcmf/export_only.yaml).

Two soft doc nits in the touched lines (nothing blocking — testbot/GVS already green):

[
  {"file": "avdnn/dlav/aml/README.md", "line": 207, "comment": "tiny nit: pretrain_only above says `optional CLE` but this row (and e2e/ptq_only) list plain `CLE` as if it always runs. the launcher filters cle jobs unless --cle-config is passed (config_loader.py `_validate_and_filter_cle_jobs`), and the MCMF cluster pipelines section below already says CLE only runs with --cle-config. consider `optional CLE` here (and on e2e/ptq_only) so the table matches.", "severity": "warning"},
  {"file": "avdnn/dlav/aml/README.md", "line": 444, "comment": "example now uses afterok for every stage including export, but the note right below says afterany is the pick for export/evaluate — reads a bit contradictory. maybe keep afterok and tweak the note, or use afterany on the export line.", "severity": "info"}
]

Drafts only — nothing posted to Gerrit; Dylan can publish these in the UI if he wants them.